[Pm-utils] pm-utils 1.2.1 and 1.1.2.5 released

[Victor Lowther]

On Sun, 2008-10-05 at 12:45 +0200, Michael Biebl wrote:
> 2008/10/4 Victor Lowther <victor.lowther at gmail.com>:
> 
> >      * pm-utils has support for saving quirks as a HAL FDI file. If
> >        called with --store-quirks-as-fdi, an .fdi file specific to the
> >        machine and quirks passed on the command line will be written
> >        to /tmp/pm-utils-created.fdi.
> 
> Btw, this doesn't seem to work for me.
> pm-suspend --store-quirks-as-fdi only does a suspend but not actually
> write the fdi file.

Stupid thinko on my part. This will fix it:

diff --git a/pm/functions.in b/pm/functions.in
index 2af9429..110282e 100644
--- a/pm/functions.in
+++ b/pm/functions.in
@@ -235,7 +235,7 @@ get_parameters() {
 # check to see if a single parameter exists
 has_parameter()
 {
-       for p in $PARAMETERS; do
+       for p in $(get_parameters); do
                [ "$p" = "$1" ] && return 0
        done
        return 1


> I'd expect that --store-quirks-as-fdi will *only* write the fdi file
> and stop afterwards.

No, it only writes the file after a sucessful sleep/wake cycle.  Less
chance of getting an incorrect .fdi file merged into hal-info that way.

> I also wonder, if we shouldn't  always reset acpi_flags to 0.
> Example: I have tested
> pm-suspend --quirk-s3-bios --quirk-s3-mode
> 
> and afterwards
> 
> pm-suspend --quirk-vbe-mode --quirk-vbestate-restore
> and /proc/sys/kernel/acpi_video_flags was still set to 3.

Yeah, that would probably make testing easier.

> Cheers,
> Michael
> 
> 
-- 
Victor Lowther
Ubuntu Certified Professional