[Pm-utils] pm-utils 1.2.1 and 1.1.2.5 released

[Victor Lowther]

On Mon, 2008-10-06 at 12:22 +0200, Michael Biebl wrote:
> 2008/10/6 Victor Lowther <victor.lowther at gmail.com>:
> > On Sun, 2008-10-05 at 23:05 +0200, Michael Biebl wrote:
> 
> >
> >> * --auto-quirks not working
> >
> > /me sighs -- I need to have hardware around that actually has the
> > aforementioned quirks, or not try to write code and sooth an infant at
> > the same time.
> >
> > diff --git a/pm/sleep.d/00auto-quirk b/pm/sleep.d/00auto-quirk
> > index 0f9bcce..839c2c0 100755
> > --- a/pm/sleep.d/00auto-quirk
> > +++ b/pm/sleep.d/00auto-quirk
> > @@ -6,7 +6,7 @@ do_add_quirks()
> >  {
> >        add_parameters $(lshal | \
> >        awk -F '[. ]' \
> > -               '/  power_management.quirk.[a-z_]+ = true/ \
> > +               '/  power_management.quirk.[0-9a-z_]+ = true/ \
> >                        {gsub(/_/, "-", $5); printf("--quirk-%s", $5)}')
> >  }
> >
> 
> We are almost there ;-)
> Now the quirks are correctly extracted, but they have to be separated
> by spaces, otherwise you get
> --quirk-s3-bios--quirk-s3-mode

hm, I thought awk would stick a newline there.  Guess I was wrong.

> diff --git a/pm/sleep.d/00auto-quirk b/pm/sleep.d/00auto-quirk
> index e45686e..5e26ae6 100755
> --- a/pm/sleep.d/00auto-quirk
> +++ b/pm/sleep.d/00auto-quirk
> @@ -7,7 +7,7 @@ do_add_quirks()
>         add_parameters $(lshal | \
>         awk -F '[. ]' \
>                 '/  power_management.quirk.[0-9a-z_]+ = true/ \
> -                       {gsub(/_/, "-", $5); printf("--quirk-%s", $5)}')
> +                       {gsub(/_/, "-", $5); printf("--quirk-%s ", $5)}')
>  }

Cool.  Next time you see any of my code sucking, go ahead and push your
fix to master or give me a branch url to pull from, ok?  I already
pushed this one and --author'ed you.

> With this patch, it finally works for me.
> 
> Unfortunately I noticed that I just missed the new release :-/

Don't worry, 1.2.2.1 is out there now. :)

Now, off to catch 30 mins of sleep while I can.

> Michael
> 
> 
> 
-- 
Victor Lowther
Ubuntu Certified Professional