[Poppler-bugs] [Bug 50992] library should be thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50992

--- Comment #17 from Adam Reichold <adamreichold at myopera.com> 2012-08-05 11:29:07 UTC ---
(In reply to comment #15)
> Created attachment 65138 [details] [review]
> Makes page rendering in splash thread safe
> 
> Here now the patch which makes page rendering thread safe. It especially offers
> a new parameter fMT (multi thread) for PDFDoc::displayPageSlice which must be
> set to gTrue if it should use in different threads with a shared PDFDoc object.
> Only splash is really thread safe with this patch, because I haven't time to
> test other output devices (and therefore didn't made the necessary changes
> there). But it should be quite easy to make also other devices thread safe now:
> just assure that nowhere the doc->getXRef() is used, use the new parameter
> given by startPage.

Hello Thomas,

I have problems compiling Poppler after applying your patch. Some places in the
code seem to call things like SplashOutputDev::startPage(0, NULL) with a
missing XRef argument. Would changing this to SplashOutputDev::startPage(0,
NULL, NULL) be ok?

Also the ArthurOutputDev does not seem to reimplement the correct method
signature. Does this pose a problem?

Regards, Adam.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.