[Poppler-bugs] [Bug 50992] library should be thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50992

--- Comment #19 from Thomas Freitag <Thomas.Freitag at alfa.de> 2012-08-05 12:48:33 UTC ---
(In reply to comment #17)
> Hello Thomas,
> 
> I have problems compiling Poppler after applying your patch. Some places in the
> code seem to call things like SplashOutputDev::startPage(0, NULL) with a
> missing XRef argument. Would changing this to SplashOutputDev::startPage(0,
> NULL, NULL) be ok?

Should be. But if You have a gfx handle, a startPage(0, NULL, gfx->getXRef())
would be the better choice to ensure thread safeness.

> 
> Also the ArthurOutputDev does not seem to reimplement the correct method
> signature. Does this pose a problem?

I didn't got anny compiler errors, so probably ArthurOutputDev isn't compiled
in my environment. Just change it like the other output devices, i.e. look at
the changes of ImageOutputDev.cc / *.h.

Cheers,
Thomas

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.