[Poppler-bugs] [Bug 53589] [PATCH] Make 'additional actions' available in Annotation API of Qt4 frontend

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=53589

--- Comment #4 from Albert Astals Cid <tsdgeos at terra.es> 2012-08-27 20:58:59 UTC ---
Comment on attachment 65698
  --> https://bugs.freedesktop.org/attachment.cgi?id=65698
Provide additional actions in Qt4 frontend API

Review of attachment 65698:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=53589&attachment=65698)
-----------------------------------------------------------------

::: qt4/src/poppler-annotation.cc
@@ +518,5 @@
> +    ::LinkAction *linkAction = 0;
> +    if ( pdfAnnot->getType() == Annot::typeScreen )
> +        linkAction = static_cast<AnnotScreen*>( pdfAnnot )->getAdditionalAction( actionType );
> +    else if ( pdfAnnot->getType() == Annot::typeWidget )
> +        linkAction = static_cast<AnnotWidget*>( pdfAnnot )->getAdditionalAction( actionType );

Not sure if i prefer this else if to be just an else (because of the if at the
beginning of the question). What do you think?

::: qt4/src/poppler-annotation.h
@@ +881,5 @@
>  
> +/**
> + * \short Widget annotation.
> + *
> + * The widget annotation represents a widget (form field) on a page.

How are apps going to match the Poppler::WidgetAnnotation with the
Poppler::FormField so they can actually do something with the action?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.