[Poppler-bugs] [Bug 53589] [PATCH] Make 'additional actions' available in Annotation API of Qt4 frontend

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=53589

--- Comment #5 from Tobias Koenig <tobias.koenig at kdab.com> 2012-08-29 11:05:11 UTC ---
(In reply to comment #4)
Hej Albert,

> ::: qt4/src/poppler-annotation.cc
> @@ +518,5 @@
> > +    ::LinkAction *linkAction = 0;
> > +    if ( pdfAnnot->getType() == Annot::typeScreen )
> > +        linkAction = static_cast<AnnotScreen*>( pdfAnnot )->getAdditionalAction( actionType );
> > +    else if ( pdfAnnot->getType() == Annot::typeWidget )
> > +        linkAction = static_cast<AnnotWidget*>( pdfAnnot )->getAdditionalAction( actionType );
> 
> Not sure if i prefer this else if to be just an else (because of the if at the
> beginning of the question). What do you think?
I have no preferences either... so shall I change it to a simple 'else'?

> > +/**
> > + * \short Widget annotation.
> > + *
> > + * The widget annotation represents a widget (form field) on a page.
> 
> How are apps going to match the Poppler::WidgetAnnotation with the
> Poppler::FormField so they can actually do something with the action?
I have not thought about that yet, since it would be out of scope of this patch
and can be added later on if somebody is implementing support for that.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.