[Poppler-bugs] [Bug 30692] [PATCH] pdftops does not crop

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30692

--- Comment #14 from William Bader <williambader at hotmail.com> ---
>if that is what you really want, why just not remove that parameter?

There are several calls to makeBox().  One of the calls to makeBox() in
PSOutputDev::checkPageSlice() uses the crop parameter.

>i do think that it is the PSOutputDev that should be modified

I think that Page::createGfx() is the right place because it calls makeBox()
(which returns both the box and the crop flag) and it makes the crop decision
when it sets arguments to new Gfx().  The further that you separate the place
that has the information from the place that makes the decision, the messier it
gets.

Wouldn't doing it anywhere else require splitting Page::createGfx() into two
parts or making more internals of Page or Gfx public?

William

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20121201/e042bea7/attachment.html>