[Poppler-bugs] [Bug 56843] [PATCH] Feature : extract media in html format

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=56843

--- Comment #15 from Albert Astals Cid <tsdgeos at terra.es> ---
+  Object obj1;
+  obj1.free();

You don't need to free the object just after creating it (it is not *wrong* per
se but it's a bit weird)

AnnotRichMedia::getConfigurations() returns a new GooList everytime but
HtmlOutputDev::doProcessRichMedia does not delete the list (i'd say you don't
need to delete the contents, but better check it). Also it'd be good if in the
header file you mention that the caller of AnnotRichMedia::getConfigurations is
the one responsible for deleting the GooList but not the contents of it (in
case i'm right)

//ok = gFalse;
Seems like it'd be a good idea to set that?

You have some commented out code in HtmlOutputDev::endPage, maybe remove it?

Besides that is looking quite good :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20121208/810af66a/attachment.html>