[Poppler-bugs] [Bug 56843] [PATCH] Feature : extract media in html format

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=56843

Allemand Corentin <corentin.allemand at aquafadas.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71088|0                           |1
        is obsolete|                            |

--- Comment #16 from Allemand Corentin <corentin.allemand at aquafadas.com> ---
Created attachment 71228
  --> https://bugs.freedesktop.org/attachment.cgi?id=71228&action=edit
Patch for extract media

(In reply to comment #15)
> +  Object obj1;
> +  obj1.free();
> 
> You don't need to free the object just after creating it (it is not *wrong*
> per se but it's a bit weird)

It's just an oversight after you have cleaned the code

> 
> AnnotRichMedia::getConfigurations() returns a new GooList everytime but
> HtmlOutputDev::doProcessRichMedia does not delete the list (i'd say you
> don't need to delete the contents, but better check it). Also it'd be good
> if in the header file you mention that the caller of
> AnnotRichMedia::getConfigurations is the one responsible for deleting the
> GooList but not the contents of it (in case i'm right)
> 
> //ok = gFalse;
> Seems like it'd be a good idea to set that?

It's just an oversight after you have cleaned the code

> 
> You have some commented out code in HtmlOutputDev::endPage, maybe remove it?

It's just an oversight after you have cleaned the code

> Besides that is looking quite good :-)

Thank you for the time to incorporate changes

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20121209/29283ec0/attachment.html>