[Poppler-bugs] [Bug 51487] Add support for TextMarkup Annotations in glib backend

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=51487

--- Comment #4 from Carlos Garcia Campos <carlosgc at gnome.org> 2012-06-28 09:10:58 PDT ---
Comment on attachment 63536
  --> https://bugs.freedesktop.org/attachment.cgi?id=63536
1/2 Patch: Add a wrapper for AnnotQuadriliterals.

Review of attachment 63536:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=51487&attachment=63536)
-----------------------------------------------------------------

Looks good in general.

::: glib/poppler-annot.cc
@@ +184,5 @@
> +                           poppler_annot_quadrilateral_copy,
> +                           poppler_annot_quadrilateral_free)
> +
> +/**
> + * poppler_rectangle_new:

This should be poppler_annot_quadrilateral_new

@@ +186,5 @@
> +
> +/**
> + * poppler_rectangle_new:
> + *
> + * Creates a new #PopplerAnnotQuadrilateral

Add a comment that this should be freed with poppler_annot_quadrilateral_free()

@@ +188,5 @@
> + * poppler_rectangle_new:
> + *
> + * Creates a new #PopplerAnnotQuadrilateral
> + *
> + * Returns: a new #PopplerAnntoQuadrilateral, use poppler_annot_quadrilateral_free() to free it

Add Since: 0.22 tag

@@ +200,5 @@
> +/**
> + * poppler_annot_quadrilateral_copy:
> + * @quad: a #PopplerAnnotQuadrilateral to copy
> + *
> + * Creates a copy of @quad

Add a comment that the returned pointer should be freed with
poppler_annot_quadrilateral_free()

@@ +202,5 @@
> + * @quad: a #PopplerAnnotQuadrilateral to copy
> + *
> + * Creates a copy of @quad
> + *
> + * Returns: a new allocated copy of @quadrilateral

parameter is quad, not quadrilateral. Add since tag here too.

::: glib/poppler-annot.h
@@ +186,5 @@
> + *  @x4: x coordinate of the fourth vertex
> + *  @y4: y coordinate of the fourth vertex
> + *  
> + *  A #PopplerAnnotQuadrilateral is used to describe
> + *  locations of annotations on a page.

Since: 0.22

@@ +198,5 @@
> +  gdouble x3;
> +  gdouble y3;
> +  gdouble x4;
> +  gdouble y4;
> +

Extra line here.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.