[Poppler-bugs] [Bug 51487] Add support for TextMarkup Annotations in glib backend

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=51487

--- Comment #5 from Carlos Garcia Campos <carlosgc at gnome.org> 2012-06-28 09:26:38 UTC ---
Comment on attachment 63537
  --> https://bugs.freedesktop.org/attachment.cgi?id=63537
2/2 Patch: Add PopplerAnnotTextMarkup

Review of attachment 63537:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=51487&attachment=63537)
-----------------------------------------------------------------

Please, split this patch, moving the demo part into its own patch.

::: glib/poppler-annot.cc
@@ +1204,5 @@
> + * use poppler_annot_get_annot_type
> + *
> + **/
> +void
> +poppler_annot_text_markup_set_annot_type (PopplerAnnotTextMarkup *poppler_annot, 

This is very weird, and annotation shoulnd't be able to change their type once
they are created. We have two options here, keep a single object
PopplerAnnotTextMarkup and add multiple constructors
(poppler_annot_text_markup_new_highlight(), etc.) or make
PopplerAnnotTextMarkup an abstract class and add a class for every markup type
deriving from PopplerAnnotTextMarkup.

@@ +1238,5 @@
> +    annot->setType (type);
> +}
> +
> +void
> +poppler_annot_text_markup_set_quads (PopplerAnnotTextMarkup    *poppler_annot,

The type is PopplerAnnotQuadrilateral so better name this
poppler_annot_text_markup_set_quadrilaterals, even if it's a nit longer.

@@ +1249,5 @@
> +  annot = static_cast<AnnotTextMarkup *>(POPPLER_ANNOT (poppler_annot)->annot);
> +}
> +
> +PopplerAnnotQuadrilateral **
> +poppler_annot_text_markup_get_quads (PopplerAnnotTextMarkup *poppler_annot,

Ditto.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.