[Poppler-bugs] [Bug 50992] library should be thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50992

--- Comment #103 from Thomas Freitag <Thomas.Freitag at alfa.de> ---
(In reply to comment #102)
> Yes, having the same rendering is important, but to be honest i like to
> understand why the code is there and why it does what it does.

And You really understand every part of poppler code :-) ? Okay, kidding aside,
I had a first deeper look into it: Annots are not thread safe because the
Catalog is not thread safe because I removed that part from the patch when I
create this page render only stuff. And I removed it because it wasn't there
when I uploaded my first thread safe patch for page rendering only (which was
regtested by me long time ago). Of course I could insert now the catalog part
again and see what happens, but then we'll probably be back to my complete
patch in a few hours.

> 
> If you want to delay the release just propose it on the mailing list, i have
> no problem, it's just random dates i throw up and stick because no one
> complains.

The problem in the code of poppler is the usage of doc and xref and
doc->getXRef() everywhere. As I mentioned: xref is not thread safe and need
therefore to be copied. I don't know a good way to make poppler thread safe in
smaller steps without any compromises. If we want to do that we have probably
to rewrite the complete code.
Therefore a delay of a few days will probably not help. Do You have any other
suggestions?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20121122/9650bfea/attachment.html>