[Poppler-bugs] [Bug 50992] library should be thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50992

--- Comment #66 from Albert Astals Cid <tsdgeos at terra.es> ---
helgrind (a valgrind tool) gives me warnings like

==32238== ----------------------------------------------------------------
==32238==
==32238== Possible data race during read of size 4 at 0x1B0929C8 by thread #10
==32238== Locks held: none
==32238==    at 0x1CDC1D02: Array::decRef() (Array.h:50)
==32238==    by 0x1CDC1802: Object::free() (Object.cc:133)
==32238==    by 0x1CD52085: Dict::~Dict() (Dict.cc:113)
==32238==    by 0x1CD62564: GfxResources::~GfxResources() (Gfx.cc:390)
==32238==    by 0x1CD7C713: Gfx::popResources() (Gfx.cc:5371)
==32238==    by 0x1CD7A5DD: Gfx::drawForm(Object*, Dict*, double*, double*,
bool, bool, GfxColorSpace*, bool, bool, bool, Function*, GfxColor*)
(Gfx.cc:4872)
==32238==    by 0x1CD7BDF1: Gfx::drawAnnot(Object*, AnnotBorder*, AnnotColor*,
double, double, double, double) (Gfx.cc:5261)
==32238==    by 0x1CD3411B: AnnotWidget::draw(Gfx*, bool) (Annot.cc:4957)
==32238==    by 0x1CDC70D3: Page::displaySlice(OutputDev*, double, double, int,
bool, bool, int, int, int, int, bool, bool (*)(void*), void*, bool (*)(Annot*,
void*), void*, bool) (Page.cc:556)
==32238==    by 0x1CDCA689: PDFDoc::displayPageSlice(OutputDev*, int, double,
double, int, bool, bool, bool, int, int, int, int, bool (*)(void*), void*, bool
(*)(Annot*, void*), void*, bool) (PDFDoc.cc:518)
==32238==    by 0x1C9F59D5: Poppler::Page::textList(Poppler::Page::Rotation)
const (poppler-page.cc:491)
==32238==    by 0x1C74B177: PDFGenerator::textPage(Okular::Page*)
(generator_pdf.cpp:968)
==32238==
==32238== This conflicts with a previous write of size 4 by thread #9
==32238== Locks held: none
==32238==    at 0x1CDC1CEA: Array::incRef() (Array.h:49)
==32238==    by 0x1CDC16CA: Object::copy(Object*) (Object.cc:99)
==32238==    by 0x1CD51E95: Dict::Dict(Dict*) (Dict.cc:88)
==32238==    by 0x1CD51EE2: Dict::copy(XRef*) (Dict.cc:93)
==32238==    by 0x1CD6221E: GfxResources::GfxResources(XRef*, Dict*,
GfxResources*) (Gfx.cc:333)
==32238==    by 0x1CD7C6CE: Gfx::pushResources(Dict*) (Gfx.cc:5364)
==32238==    by 0x1CD79F5A: Gfx::drawForm(Object*, Dict*, double*, double*,
bool, bool, GfxColorSpace*, bool, bool, bool, Function*, GfxColor*)
(Gfx.cc:4789)
==32238==    by 0x1CD7BDF1: Gfx::drawAnnot(Object*, AnnotBorder*, AnnotColor*,
double, double, double, double) (Gfx.cc:5261)
==32238==
==32238== Address 0x1B0929C8 is 24 bytes inside a block of size 32 alloc'd
==32238==    at 0x4C2B377: operator new(unsigned long) (in
/usr/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
==32238==    by 0x1CDC1530: Object::initArray(XRef*) (Object.cc:66)
==32238==    by 0x1CDC87E9: Parser::getObj(Object*, bool, unsigned char*,
CryptAlgorithm, int, int, int, int, bool) (Parser.cc:91)
==32238==    by 0x1CDC8AA9: Parser::getObj(Object*, bool, unsigned char*,
CryptAlgorithm, int, int, int, int, bool) (Parser.cc:119)
==32238==    by 0x1CDE3A6B: XRef::fetch(int, int, Object*, int) (XRef.cc:1161)
==32238==    by 0x1CDC175E: Object::fetch(XRef*, Object*, int) (Object.cc:121)
==32238==    by 0x1CD5250D: Dict::lookup(char const*, Object*, int)
(Dict.cc:220)
==32238==    by 0x1CD3BC6A: Object::dictLookup(char const*, Object*, int) (in
/home/kdeunstable/instalado/lib/libpoppler.so.29.0.0)
==32238==    by 0x1CD5889B: Form::Form(PDFDoc*, Object*) (Form.cc:1329)
==32238==    by 0x1CD44235: Catalog::getForm() (Catalog.cc:920)
==32238==    by 0x1CD3AF7C: Annots::createAnnot(Dict*, Object*) (Annot.cc:6568)
==32238==    by 0x1CD3A7AF: Annots::Annots(PDFDoc*, int, Object*)
(Annot.cc:6478)

Do we need some more locks or helgrind is just reporting wrong?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20121001/d8050ca3/attachment.html>