[Poppler-bugs] [Bug 55378] [PATCH] make LinkRendition properties available in Qt4 frontend
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Mon Oct 1 13:34:05 PDT 2012
https://bugs.freedesktop.org/show_bug.cgi?id=55378
--- Comment #2 from Albert Astals Cid <tsdgeos at terra.es> ---
Could you try to avoid whitespace only changes? I know you are actually fixing
stuff but it makes the patches a bit harder to review.
The "delete linkAction;" removal seems like it does not belong to this patch?
We don't have an enum for the operations thing in the poppler core? Maybe it's
worth adding?
Could you keep the old LinkRendition constructor and mark it as deprecated so
we don't break the ABI unccessesarly?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20121001/7141b06c/attachment.html>
More information about the Poppler-bugs
mailing list