[Poppler-bugs] [Bug 50992] library should be thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50992

Thomas Freitag <Thomas.Freitag at alfa.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67852|0                           |1
        is obsolete|                            |

--- Comment #67 from Thomas Freitag <Thomas.Freitag at alfa.de> ---
Created attachment 68025
  --> https://bugs.freedesktop.org/attachment.cgi?id=68025&action=edit
lock inc/decRef final patch two

(In reply to comment #66)
> 
> Do we need some more locks or helgrind is just reporting wrong?

helgrind is reporting right, we need some more locks (even if I cannot
reconstruct it: if I start okular with helgrind, I get tons of error messages
in the qt area, but I can't find a report like Yours).
I'm not completely sure if in this case it would be better to copy the array,
too. But I haven't found a testcase for it, and locks are needed in either
case, not only for arrays, but for dicts and streams, too, because it is
possible that they are shared over threads in some cases.
BTW, because I had to create a new patch anyway, I also changed the getDocInfo
stuff now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20121003/f117bd90/attachment.html>