[Poppler-bugs] [Bug 55977] handling of rtl text inversion is too naive

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55977

--- Comment #3 from alex <alexbodn.groups at gmail.com> ---
(In reply to comment #2)
> Hi, thanks for the contribution!

hello, thanks a lot for considering my patch. and more for your work on this
great project.
> 
> Some weak points of the patch (have not really looked at the contents yet,
> just at the form):
>  * You are missing support for the cmake build system
i don't know cmake, but will happily add support for it. how and where?
>  * You are exposing the #if HAVE_ICU in TextOutputDev.h (for a variable i
> never see you assign or change)
the reorderingMode enum has values taken from an icu header. indeed the enum
declaration itself should depend on have_icu. will fix.
>  * If i have icu and fribidi it will say that both are used, when that's not
> true (please switch it to something like the cms check that says "with lcms"
> or "with lcms2" depending on the library used)
indeed, this might need some thought in configure.ac. like trying fribidi only
if icu is missing. this is the behaviour in the TextOutputDev anyway. what
would you think?

best regards,
alex

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20121015/41b3c99b/attachment.html>