[Poppler-bugs] [Bug 55977] handling of rtl text inversion is too naive

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55977

--- Comment #2 from Albert Astals Cid <tsdgeos at terra.es> ---
Hi, thanks for the contribution!

Some weak points of the patch (have not really looked at the contents yet, just
at the form):
 * You are missing support for the cmake build system
 * You are exposing the #if HAVE_ICU in TextOutputDev.h (for a variable i never
see you assign or change)
 * If i have icu and fribidi it will say that both are used, when that's not
true (please switch it to something like the cms check that says "with lcms" or
"with lcms2" depending on the library used)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20121014/4c722998/attachment.html>