[Poppler-bugs] [Bug 50992] library should be thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50992

--- Comment #69 from Adam Reichold <adamreichold at myopera.com> ---
(In reply to comment #68)
> Created attachment 68840 [details] [review]
> a new rebased patch
> 
> I just encountered that the patch is no more appliable. So I created a
> rebased patch. I also changed the preprocessor directive to
> POPPLER_QT4_OVERPRINT_PREVIEW how Adam mentioned.

Limited testing of parallel rendering using this latest patch does seem to work
as expected.

Concerning a more fundamental question: It is a big patch, so it takes very
much to review and I understand that it does not get into master easily. But it
seems a lot of work to continuous rebase it. From looking at the code, it seems
unlikely to me that it will introduce regressions in the _single-threaded_
usage of Poppler, i.e. programs that do not take advantage of these changes
should not be affected. (Aside from the slight performance decrease because of
less sharing that is.)

I really do not want to be presumptuous. I am not the maintainer, so I do not
have to make the though calls. However, my personal opinion is that it would
probably make sense to be bold and push this even if we find a few problems by
long-time usage. (It could also receive more testing in the Poppler prereleases
leading to 0.22 this way.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20121021/5774b44e/attachment-0001.html>