[Poppler-bugs] [Bug 50992] library should be thread-safe

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Sep 25 21:38:12 PDT 2012


https://bugs.freedesktop.org/show_bug.cgi?id=50992

--- Comment #49 from Adam Reichold <adamreichold at myopera.com> ---
(In reply to comment #48)
> The poppler patch fails to apply on master.

Did you try "git apply --ignore-space-change"?

(In reply to comment #47)
> (In reply to comment #43)
> > Created attachment 67636 [details] [review] [review]
> > more changes to get qt library thread safe
> > 
> > This patch also inlcudes the changes from Adam. I went through the code of
> > okular and tried to make all calls of the poppler qt library thread safe.
> 
> What are the incref and decref in Document supposed to do?

I think they are supposed to the delete the document instance after the last
thread that uses it has finished which might be after the thread that create
it. Otherwise, the main, e.g. GUI, thread would have to wait for all work
threads to finish before deletion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20120926/7496119e/attachment.html>


More information about the Poppler-bugs mailing list