[Poppler-bugs] [Bug 50992] library should be thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50992

--- Comment #54 from Albert Astals Cid <tsdgeos at terra.es> ---
Some quick comments before i have a change to try it in 2 hours or so.

The Annot.cc change does not belong here, right?

The recursion in Stream::addFilters does not belong here either i'd say, no?

GBool fCopy seems a bad name for something that decides if the xref is going to
be copied, can we call it copyXRef? Same for fMT

Seems a bit weird leaving the non thread safe versions of getDocInfo and
getDocInfoNF there, no? What's the use of them?

In the qt4 frontend we don't need the incRef and decRef, that's poor's man
solution. Users of qt4 frontend can put the Document * in a QSharedPointer to
get the reference counting properly done (which by the way we should not need
in Okular since the code ensure the PDF generator will only be deleted once all
the threads have finished)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20120926/7f479724/attachment-0001.html>