[Poppler-bugs] [Bug 50992] library should be thread-safe

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sat Sep 29 08:42:37 PDT 2012


https://bugs.freedesktop.org/show_bug.cgi?id=50992

Thomas Freitag <Thomas.Freitag at alfa.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67775|0                           |1
        is obsolete|                            |

--- Comment #61 from Thomas Freitag <Thomas.Freitag at alfa.de> ---
Created attachment 67852
  --> https://bugs.freedesktop.org/attachment.cgi?id=67852&action=edit
final thread safe patch

When I uploaded my patch on thursday I still wasn't completely satisfied with
the catalog implementation: Even if it works, I saw possible gaps. So I worked
on a more complete version today morning.
After that I made several valgrind tests and found three memory leaks, two in
my implementation of this patch, which I solved, and one, which doesn't depend
on this patch but where I already uploaded a patch to bug 54702.
After that I run a regtest with pdftoppm (with my testcase, which uses threads)
and one with pdftocairo (without using threads) and didn't find any further
problems.
I also made again okular tests, following content, add annotations, save as PDF
with filled forms, everything worked fine. The only problem I had was when
opening a PDF with sound, it didn't play. But I think it is because I use
okular under ubuntu without having the correct player installed (or isn't it
possible at all?).
So I upload here my (first) final patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20120929/82adb697/attachment.html>


More information about the Poppler-bugs mailing list