[Poppler-bugs] [Bug 73111] Cannot compile poppler with Qt5 frontend on Win 8 with Visual Studio 2012

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=73111

--- Comment #3 from Adrian Johnson <ajohnson at redneon.com> ---
(In reply to comment #2)
> Created attachment 91276 [details] [review]
> patch for poppler compilation with Qt5 frontend on Win8 with VS 2012

The #define NOMINAX should go in each header file that include windows.h.
Otherwise we will have the same problem the next time someone adds a max or min
to another file.

> Here is the patch with the suggested correction. I would also recommend to
> replace all _WIN32 with _MSC_VER which is more generic than looking for
> _WIN32 only

_WIN32 is defined when compiling for the windows platform. _MSC_VER is defined
when compiling with VC++. If compiling with MinGW (either natively or cross
compiling) _WIN32 will be defined but not _MSC_VER.

Looking at your patch the you should be using _WIN32 as it is all windows
platform specific stuff (generally anything related to windows.h). _MSC_VER is
only used to handle the differences between VC++ and GCC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131229/69289cab/attachment-0001.html>