[Poppler-bugs] [Bug 59927] make qt4 frontend thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=59927

--- Comment #18 from Adam Reichold <adamreichold at myopera.com> ---
(In reply to comment #17)
> (In reply to comment #16)
> > Commited, are we done in this one?
> > 
> > P.S: Just had a look at the construct of Page::getResourceDict and i think
> > it's a bit unseasy to use, do you think that in the "cleanup" bug we could
> > instead use two functions? One that always does the copy and one that not?
> > Now you have to keep track if you passed down a non null XRef to know if you
> > have to delete it or not, which i think may be a bit cumbersome and error
> > prone, what do you think?
> 
> I'LL have a look at it abd try to find a better solution in bug 59933.
> 
> BTW, during my tests with Adam's program I got one or two times crashes. But
> the reason for it was the test program itself: two threads fetched the page
> annots (without any problems) and the deleted the same annotation, the first
> one wins and the second could crash. I cannot solve that in the library,
> this is the one case I know where the calling program is responsible to lock
> two threads against each other.

I agree, as is stated in the documentation, the caller is responsible that no
more objects refer to a specific annotation before calling
"Page::removeAnnotation", so this is invalid usage, even if it is done in a
single thread.

> @Adam: Any known open issues or can we close this bug now?

Nothing comes to mind.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130221/c458dafa/attachment.html>