[Poppler-bugs] [Bug 44085] pdfinfo/pdffonts cannot process >2GB files

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=44085

Thomas Freitag <Thomas.Freitag at alfa.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72449|0                           |1
        is obsolete|                            |

--- Comment #25 from Thomas Freitag <Thomas.Freitag at alfa.de> ---
Created attachment 72539
  --> https://bugs.freedesktop.org/attachment.cgi?id=72539&action=edit
fix uninitialized memory

(In reply to comment #24)
> Created attachment 72449 [details] [review]
> fix uninitialised memory
> 
> I've found the rendering differences for bug-poppler26533.pdf to be caused
> by uninitialised memory in splash. This patch fixes the problem.

Thanks for figuring out why almost all tests failed if a page using tiling
patterns. But I think Your patch is slightly incomplete: 
1. You remove the initialization of the bitmap if paintType = 2 is used. This
paintType is seldom used, one example is page 745 of spec PDF32000_2008.pdf.
2. I think the better way to initialize the memory is to use the paperColor
(which in pdftoppm is the same You're using: white) and use the existing
Splash::clear function.
This patch changes it and therefore should replace Your patch for it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130105/e8e92c41/attachment.html>