[Poppler-bugs] [Bug 50992] library should be thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50992

Thomas Freitag <Thomas.Freitag at alfa.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72952|0                           |1
        is obsolete|                            |

--- Comment #136 from Thomas Freitag <Thomas.Freitag at alfa.de> ---
Created attachment 72996
  --> https://bugs.freedesktop.org/attachment.cgi?id=72996&action=edit
Additional locks for bug-poppler10898.pdf

(In reply to comment #135)
> With attachment.cgi?id=72952 bug-poppler10898.pdf is crashing on me again
> with the while loop

When I read Your comment today early morning I immediately started a new
while-loop test. After half a hour I started writing a new comment, but just
before I wanted to press the submit button, the test crashed. Unfortunately I
forgot to allow core dumps, so I couldn't figure out the reason.
The former reason for crashes is definitely solved: two threads were calling
Dict::copy on the same dict at the same time, but because Dict:copy also
modifies the dict entry object, this caused the crashes. I solved that by
inserting lock/unlock pairs in the method. 
Because I have no core dump and You also didn't attach backtraces, I've to
guess now: In the crashes before there was always also an array involved, but
there are no lock/unlock pairs in the array implementation. I tried to proof
that idea, starting the while-loop test with the clang compiled version 2 hours
ago.
In the meantime I inserted the lock/unlock pairs in the array implementation,
run a complete regtest on this new version, but the clang version is still
running.
So I upload the new patch now and ask You to test it, too, and provide a
backtrace if it still crashes. I'll stop now the clang test and start a normal
test with core dumps enables, too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130114/ba5177ec/attachment.html>