[Poppler-bugs] [Bug 59927] make qt4 frontend thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=59927

--- Comment #2 from Adam Reichold <adamreichold at myopera.com> ---
(In reply to comment #1)
> Created attachment 73725 [details] [review]
> okular testcase
> 
> And here my okular testcase.
> @Adam: I allow me to add You to the CC list. One of the reasons is that I
> can't reconstruct the problems with Page::search, okular uses Page::textList
> instead of it, and that was already thread-safe with commit of bug 50992. If
> You still get problems with Page::search, can You provide a testcase for it
> or tell me, how I can reconstruct it?

Thanks for keeping me in the loop! As you already pointed out on the mailing
list, changing the call to displayPage using the TextOutputDev and hence this
patch seems to have solved the search-while-render problem.

Concerning the POPPLER_QT4_THREADSAFE definition, I could personally live
without it since I build with defines for the Poppler version given by
pkg-config. But I also do not see a problem with it and advertising this
feature is probably nice as well.

To round it up and get a definite statement: With this patch applied, I can
consider the complete qt4 frontend thread-safe? Meaning that I can remove all
locks that protect a document object and its children? (Including life cycle
stuff like adding annotations?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130127/be88a927/attachment.html>