[Poppler-bugs] [Bug 59179] Some colors appear grey/black, whereas it works with Adobe Reader

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jan 28 06:57:15 PST 2013


https://bugs.freedesktop.org/show_bug.cgi?id=59179

--- Comment #7 from Carlos Garcia Campos <carlosgc at gnome.org> ---
(In reply to comment #6)
> Created attachment 73644 [details] [review]
> support uncolored tiling patterns
> 
> It turns out that we can't use cairo_mask for uncolored patterns since
> cairo_mask uses the alpha and not the luminosity to mask the source.
> 
> This patch uses the same solution as uncolored patterns in PSOutputDev. It
> adds a flag to indicate we are rendering an uncolored pattern and disables
> setting the color when the flag is true.

Great, no regressions this time. Thanks! Please, don't use braces for single
statement ifs. Feel free to push.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130128/46398e27/attachment.html>


More information about the Poppler-bugs mailing list