[Poppler-bugs] [Bug 65551] cppcheck report

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sun Jun 9 03:37:39 PDT 2013


https://bugs.freedesktop.org/show_bug.cgi?id=65551

--- Comment #5 from Julien Nabet <serval2412 at yahoo.fr> ---
Thank you Albert for your quick feedback.

However, there are still some like these:
[splash/Splash.cc:3802] -> [splash/Splash.cc:3802]: (style) Same expression on
both sides of '||'
[utils/HtmlOutputDev.cc:1704]: (error) Memory leak: str
[poppler/Annot.cc:3161] -> [poppler/Annot.cc:3159]: (style) Found duplicate
branches for 'if' and 'else'.
[poppler/Annot.cc:3859] -> [poppler/Annot.cc:3857]: (style) Found duplicate
branches for 'if' and 'else'.
which may not only style problem. (on the contrary of Reduce scope, casting,
etc). 

I'll try to send other patches in the next days for style. (except casts
because I never know when to use dynamic cast vs static cast for eg)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130609/47e282ca/attachment.html>


More information about the Poppler-bugs mailing list