[Poppler-bugs] [Bug 62735] Should not try to fopen a file we already have open

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=62735

--- Comment #9 from Adrian Johnson <ajohnson at redneon.com> ---
(In reply to comment #5)
> Created attachment 77021 [details] [review]
> patch to keep using old-style I/O on Win32
> 
> This slightly convoluted patch uses #ifdefs to keep the old-style I/O, and
> UniqueFileStream as an implementation detail, around for Win32. *Not tested
> on an actual Win32 host.*
> 
> (This is so ugly... Couldn't Poppler depend on Cygwin or some other form of
> POSIX layer... :-()

It would be nice to have a solution that didn't require all the #ifdefs. I know
this is what we have done in the past but it would be better if the #ifdefs
were confined to the header files and win32 specific code is put in a separate
file. This also avoids polluting the namespace with all the junk in windows.h.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130326/cdfba11f/attachment.html>