[Poppler-bugs] [Bug 51487] [PATCH] Add support for TextMarkup Annotations in glib frontend

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=51487

--- Comment #25 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 88272
  --> https://bugs.freedesktop.org/attachment.cgi?id=88272
glib-demo: Add support for PopplerTextAnnotMarkup

Review of attachment 88272:
-----------------------------------------------------------------

::: glib/poppler-annot.cc
@@ +202,4 @@
>  {
>  }
>  
> +/* PopplerRectangle type */

Wrong comment

@@ +203,5 @@
>  }
>  
> +/* PopplerRectangle type */
> +
> +POPPLER_DEFINE_BOXED_TYPE (PopplerAnnotQuadrilateral, poppler_annot_quadrilateral,

I think this could be PopplerQuadrilateral, this is very generic boxed type
even if it's only used by annots.

@@ +214,5 @@
> + * Creates a new #PopplerAnnotQuadrilateral. It must be freed with poppler_annot_quadrilateral_free() after use.
> + *
> + * Returns: a new #PopplerAnnotQuadrilateral.
> + *
> + * Since: 0.25

0.26

@@ +217,5 @@
> + *
> + * Since: 0.25
> + **/
> +PopplerAnnotQuadrilateral *
> +poppler_annot_quadrilateral_new (void)

I think the constructor should receive the points.

::: glib/poppler-annot.h
@@ +226,5 @@
> +  gdouble y2;
> +  gdouble x3;
> +  gdouble y3;
> +  gdouble x4;
> +  gdouble y4;

If we had PopplerPoint or PopplerVertex we could use it here too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131103/8e536651/attachment-0001.html>