[Poppler-bugs] [Bug 64821] [TAGGEDPDF] Expose the structure tree and attributes in poppler-glib

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=64821

--- Comment #25 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 86683
  --> https://bugs.freedesktop.org/attachment.cgi?id=86683
[PATCH v8 10/15] glib: Private function
_poppler_link_mapping_new_from_form_field()

Review of attachment 86683:
-----------------------------------------------------------------

::: glib/poppler-page.cc
@@ +1280,5 @@
> +  Page *page;
> +
> +  g_assert (POPPLER_IS_FORM_FIELD (form_field));
> +  g_assert (page_num >= 0);
> +  g_assert (page_num < poppler_document_get_n_pages (form_field->document));

Same comments here, this asserts look a bit too paranoid for me.

@@ +1325,4 @@
>    
>    for (i = 0; i < forms->getNumWidgets (); i++) {
>      PopplerFormFieldMapping *mapping;
> +    PopplerFormField *field = _poppler_form_field_new (page->document,

If you split this too, you can use a single line for _poppler_form_field_new

@@ +1330,3 @@
>  
> +    mapping = _poppler_form_field_mapping_new_from_form_field (field,
> +							       page->index);

Use a single line here too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131105/5625ce73/attachment.html>