[Poppler-bugs] [Bug 70901] Add getter and setter for annotation's rectangle

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Nov 6 00:02:23 PST 2013


https://bugs.freedesktop.org/show_bug.cgi?id=70901

--- Comment #4 from Carlos Garcia Campos <carlosgc at gnome.org> ---
(In reply to comment #2)
> Comment on attachment 88161 [details] [review]
> glib: Add getter and setter for annotation's rectangle
> 
> Review of attachment 88161 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: glib/poppler-annot.cc
> @@ +719,5 @@
> > + * Since: 0.25
> > + **/
> > +void
> > +poppler_annot_set_rectangle (PopplerAnnot    *poppler_annot,
> > +			     PopplerRectangle poppler_rect)
> 
> We still need to call setRect with the coordinates.  PopplerRectangle
> (struct) does not map to PDFRectangle (class).

Yes, I mean to use a pointer for the parameter so that the caller can do:

PopplerRectangle rect = { 1, 2, 3, 4 };
poppler_annot_set_rectangle (annot, &rect);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131106/5afbec10/attachment.html>


More information about the Poppler-bugs mailing list