[Poppler-bugs] [Bug 69978] Make demo extensible for other type of annotations

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69978

--- Comment #29 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 88199
  --> https://bugs.freedesktop.org/attachment.cgi?id=88199
glib-demo: Add annotations interactively

Review of attachment 88199:
-----------------------------------------------------------------

::: glib/demo/annots.c
@@ +825,5 @@
> +    rect.x2 = demo->stop.x;
> +    rect.y2 = height - demo->stop.y;
> +    switch (demo->annot_type) {
> +        case POPPLER_ANNOT_TEXT:
> +            annot = poppler_annot_text_new (demo->doc, &rect);

The annotation is leaked here. When it's added to the model, the model takes a
reference, and this one is never released, so we should call g_object_unref
after add_annot_to_model

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131117/ed606b1e/attachment.html>