[Poppler-bugs] [Bug 70981] glib-demo: Add support for simple line annotations

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70981

--- Comment #18 from Germán Poo-Caamaño <gpoo at gnome.org> ---
(In reply to comment #17)
> (In reply to comment #13)
> > (In reply to comment #9)
> > > Comment on attachment 89308 [details] [review] [review] [review]
> > > [...]
> > > @@ +1505,5 @@
> > > > + */
> > > > +void
> > > > +poppler_annot_line_set_vertices (PopplerAnnotLine *poppler_annot,
> > > > +                                 PopplerPoint start,
> > > > +				 PopplerPoint end)
> > > 
> > > Use pointers for start and end
> > 
> > why do you prefer pointers on this one?
> 
> To avoid copying the struct like in the poppler_annot_set_rectangle case.

Ok, thanks.  FWIW, the patch addresses this and the other comments.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131118/a97bd146/attachment.html>