[Poppler-bugs] [Bug 70983] Add implementation of Square and Circle annotations

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70983

--- Comment #3 from Germán Poo-Caamaño <gpoo at gnome.org> ---
(In reply to comment #2)
> @@ +433,5 @@
> > +  border = new AnnotBorderArray ();
> > +  border->setWidth (1.5);
> > +
> > +  annot = new AnnotGeometry (doc->doc, &pdf_rect, Annot::typeCircle);
> > +  annot->setBorder (border);
> 
> Why do we set a border by default? The BS entry is optional.

If we don't set the border, we get an "invisible" square/circle.
One way to enable it is good a sensible default.  The alternatives
are:
- A hard coded sensible default
- Receive *line_width, if NULL then not set anything. Otherwise,
  set the width.
- Add in the documentation that to create a visible circle/square it is
  required to call an additional method (set_border_width) afterwards.
- Not do anything at all

I am going to submit an updated patch with last one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131118/3910a749/attachment.html>