[Poppler-bugs] [Bug 70982] glib-demo: Simplify the list view for annotations

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70982

--- Comment #6 from Germán Poo-Caamaño <gpoo at gnome.org> ---
(In reply to comment #5)
> Comment on attachment 89392 [details] [review]
> glib-demo: Simplify annotations list and its properties
> 
> Review of attachment 89392 [details] [review]:
> -----------------------------------------------------------------
> 
> I'm not sure about this, I find it a bit confusing. This is what I see with
> my spanish locale:
> 
> Coords: (152,0,556,0) (152,0,556,0)
> 
> Maybe we could use something like:
> 
> Coords: X1: aa,bb X2: aa,bb Y1: aa,bb Y2: aa,bb
> 
> Which is what we currently have in the list but moved to a label in the
> properties.

I was trying to save space, so no need to resize the sidebar pane and leaving
space to the rendering page.  I had forgotten about the locale thing, though.

Maybe we can use semicolon instead a comma, something like:
     (152,0;556,0) (152,0;556,0)
or a dash:
     (152,0-556,0) (152,0-556,0)

FWIW, I was also inclined to removed the decimals, but the PDF has decimals
(for the annotations added with other software). The ones created with cairo,
are integers.

> The coords information is mainly useful when debugging, but now that we have
> the view also in the annots demo, it would be really useful to paint a focus
> ring around the currently selected annot. But that could be done as a follow
> up patch.

Indeed, the reason to save space and avoid the scrollbars in the side pane was
precisely because it was becoming a pain to debug the coordinates when I was
testing it :-)

The focus ring would be good. IIRC, I had it done in an Evince patch I have.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131119/be4e0821/attachment.html>