[Poppler-bugs] [Bug 51487] [PATCH] Add support for TextMarkup Annotations in glib frontend

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=51487

--- Comment #30 from Carlos Garcia Campos <carlosgc at gnome.org> ---
(In reply to comment #28)
> (In reply to comment #25)
> > Comment on attachment 88272 [details] [review] [review]
> > glib-demo: Add support for PopplerTextAnnotMarkup
> > 
> > Review of attachment 88272 [details] [review] [review]:
> > -----------------------------------------------------------------
> > [...]
> > @@ +217,5 @@
> > > + *
> > > + * Since: 0.25
> > > + **/
> > > +PopplerAnnotQuadrilateral *
> > > +poppler_annot_quadrilateral_new (void)
> > 
> > I think the constructor should receive the points.
> 
> Shouldn't that be inconsistent with other similar boxed types such as
> PopplerPoint, PopplerRectangle, PopplerColor?

Good point.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131119/ecd60121/attachment.html>