[Poppler-bugs] [Bug 71704] Some improvements in reading the hints table

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=71704

--- Comment #6 from Hib Eris <hib at hiberis.nl> ---
(In reply to comment #5)
> Right, but as far as i can see you're discarding those bits (since you're
> not assigning the readBits call to anything) so what's the problem?

That is correct, there is not really a problem with it right now because the
shared object signature is not used anywhere.

Using readBits(128) to _skip _over the shared object signature works, but when
you would use it to _read_ it, it would not work / give you undefined behavior.

As the readBits function will give undefined results when called with n > 32 I
think it would be prudent to not use it with n = 128.

It may be even better to have readBits assert (n <= 32).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131120/89670f02/attachment.html>