[Poppler-bugs] [Bug 71704] Some improvements in reading the hints table

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=71704

--- Comment #7 from Albert Astals Cid <aacid at kde.org> ---
(In reply to comment #6)
> Using readBits(128) to _skip _over the shared object signature works, but
> when you would use it to _read_ it, it would not work / give you undefined
> behavior.

Exactly and since what we're doing is skipping and not reading (and it's even
kind of commented in the file) i think it's better to have a single readBits
than 4 of them, i mean, if I look at the new code, i will wonder why there's 4
calls that do "nothing" when there could be only one that does the same amount
of "nothing".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131120/a1f306d9/attachment.html>