[Poppler-bugs] [Bug 68420] Cache lcms transformed values for ICC colorspaces in getRGB(), getCMYK() and getGray()

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=68420

--- Comment #5 from Albert Astals Cid <aacid at kde.org> ---
I do get a reasonable increase too, from 2400ms to 1800ms

Two things:
 * It'd be cool if we could reuse the key and not calculate it twice, but then
it'll probably make the code harder to read, so ignore

 * It'd be cool if we had "a proper cache" and not just cache the first 2048
items, so probably ignore too :D

Only thing, is i think i prefer #define CMSCACHE_LIMIT 2048 in the .cc and not
in the header, but that's just me nitpicking.

So should i start the regtest just in case something bad went wrong or you
prefer to get bug 34053 commited first as you say in the bug description?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130925/3c24865c/attachment.html>