[Poppler-bugs] [Bug 84555] reproducible crash with some PDF files

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=84555

Carlos Garcia Campos <carlosgc at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Carlos Garcia Campos <carlosgc at gnome.org> ---
(In reply to Jason Crain from comment #6)
> Created attachment 111069 [details] [review]
> Move array reallocation from visitLine to startLine
> 
> If TextSelectionDumper finds exactly 257 lines of text (or probably also
> 513, 1025, etc) it will write past the end of the lines array without
> triggering a reallocation.
> 
> Attached patch moves the array size check into
> TextSelectionDumper::finishLine so it's always run when an item is added to
> the lines array.

Good catch! I've just pushed it, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20141220/c14700dc/attachment.html>