[Poppler-bugs] [Bug 64821] [TAGGEDPDF] Expose the structure tree and attributes in poppler-glib

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=64821

--- Comment #55 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 90266
  --> https://bugs.freedesktop.org/attachment.cgi?id=90266
[PATCH v12 09/11] glib: Accessors for document structure references

Review of attachment 90266:
-----------------------------------------------------------------

::: glib/poppler-structure-element.cc
@@ +819,5 @@
>  
>  /**
> + * poppler_structure_element_get_form_field:
> + * @poppler_structure_element: A #PopplerStructureElement
> + *

You should explain briefly here what this method is for.

@@ +822,5 @@
> + * @poppler_structure_element: A #PopplerStructureElement
> + *
> + * Return value: (transfer full): A #PopplerFormField, or %NULL if
> + *    the element is not a %POPPLER_STRUCTURE_ELEMENT_FORM.
> + */

Since: 0.26

@@ +827,5 @@
> +PopplerFormField *
> +poppler_structure_element_get_form_field (PopplerStructureElement *poppler_structure_element)
> +{
> +  g_return_val_if_fail (POPPLER_IS_STRUCTURE_ELEMENT (poppler_structure_element), NULL);
> +  g_assert (poppler_structure_element->elem);

Use g_return macros in public elements.

@@ +861,5 @@
> +                                                                  field_id);
> +}
> +
> +/**
> + * poppler_structure_element_get_form_field_mapping:

I still think this method is a bit weird. I think it should be the page the one
returning a mapping.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20140209/ff74e520/attachment-0001.html>