[Poppler-bugs] [Bug 79874] Compilation of Qt5 frontend fails with MinGW

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=79874

--- Comment #2 from Aki Koskinen <freedesktop at akikoskinen.info> ---
(In reply to comment #1)
> hmmmm, i'm unconvinced by the patch, can poppler compiled that way still
> open files with non-ascii characters?

I'm not sure. It's completely OK to discard the proposed patch.

Another way (possibly better) would be to replace the non-standard _Copy_s with
something standard, like copy. The additional bounds checking provided by
_Copy_s doesn't seem to bring any benefit since we already know that fileName
is large enough (since we just constructed it).

Or then not copy at all - I don't quite get why the copying is needed in the
first place. Would something like this do the job (note: untested code):

doc = new PDFDoc((const wchar_t *)filePath.utf16(), filePath.length(),
ownerPassword, userPassword);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20140613/b876db58/attachment.html>