[Poppler-bugs] [Bug 75796] [TAGGEDPDF] Accomodate for future extension of poppler_structure_element_get_text()

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=75796

--- Comment #1 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 95165
  --> https://bugs.freedesktop.org/attachment.cgi?id=95165
[PATCH] glib: Use flags argument in poppler_structure_element_get_text()

Review of attachment 95165:
-----------------------------------------------------------------

::: glib/poppler-structure-element.cc
@@ +666,4 @@
>  /**
>   * poppler_structure_element_get_text:
>   * @poppler_structure_element: A #PopplerStructureElement
> + * @flags: A #PopplerStructureGetTextFlags value, or %0 to disable

Yes, this is much better than a boolean parameter, but please, use a value in
the enum instead of this 0 here. Something like POPPLER_STRUCTURE_GET_TEXT_NONE

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20140306/1a7ca49f/attachment.html>