[Poppler-bugs] [Bug 76445] SEGV in RescaleDrawImage::getRow

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Mar 28 07:27:22 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=76445

--- Comment #5 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 96518
  --> https://bugs.freedesktop.org/attachment.cgi?id=96518
fix segv

Review of attachment 96518:
-----------------------------------------------------------------

Thanks Adrian, I have a couple of questions

::: poppler/CairoOutputDev.cc
@@ +2839,4 @@
>        current_row++;
>      }
>  
> +    if (unlikely(pix == NULL)) {

So, if I understand correctly, the problem is that for buggy PDF documents,
ImageStream::getLine can return NULL, right? What about the other places where
we use it too? Could we make getRow() return bool and abort the image decode
when it returns false?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20140328/1e576d89/attachment.html>


More information about the Poppler-bugs mailing list