[Poppler-bugs] [Bug 80719] pdftocairo -svg renders a jpeg image with inverted color

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80719

--- Comment #6 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 107384
  --> https://bugs.freedesktop.org/attachment.cgi?id=107384
only embed mime data if decode map is  identity

Review of attachment 107384:
-----------------------------------------------------------------

::: poppler/CairoOutputDev.cc
@@ +2719,5 @@
> +  // only embed mime data if image decode map is identiy
> +  for (i = 0; i < colorMap->getNumPixelComps(); i++) {
> +    if (colorMap->getDecodeLow(i) != 0.0 || colorMap->getDecodeHigh(i) != 1.0)
> +      return;
> +  }

Looks good, maybe we could add a helper method for this, and we don't need the
comment to explain it. something like:

if (!colorMapHasIdentityDecodeMap(colorMap))
  return;

Or something similar.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20141006/e578b393/attachment.html>