[Poppler-bugs] [Bug 79936] Add support for printing to a Windows printer from pdftocairo

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=79936

--- Comment #33 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 106267
  --> https://bugs.freedesktop.org/attachment.cgi?id=106267
Allow an output file for win32 printing to be specified

Review of attachment 106267:
-----------------------------------------------------------------

why GSView? :-P Patch LGTM

::: utils/pdftocairo-win32.cc
@@ +188,5 @@
> +    docinfo.lpszDocName = inputFileName->getCString();
> +  }
> +  if (outputFileName) {
> +    docinfo.lpszOutput = outputFileName->getCString();
> +  }

Why have you added braces everywhere?

::: utils/pdftocairo.cc
@@ +741,5 @@
>    }
>  
> +  if (print) {
> +    return NULL; // No output file means print to printer
> +  }

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20140927/c918a0e3/attachment.html>