[Poppler-bugs] [Bug 89952] Memory leak with duplicate font

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89952

--- Comment #2 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 114947
  --> https://bugs.freedesktop.org/attachment.cgi?id=114947
Free font data when we find duplicate

Review of attachment 114947:
-----------------------------------------------------------------

The commit message is a bit confusing, this only happens when _ft_new_face is
called with font_data + font_data_len (embedded fonts). I wonder if we should
release that data in more cases, because _ft_done_face is assuming the data is
mmaped. So, for example, when FT_New_Memory_Face fails, we should also free the
data? Should we check in _ft_done_face if data->fd is -1 to do the unmap ro
gfree? I'm confused, because _ft_done_face should fail for embedded fonts, or
it's simply never called due to the cairo cache being always alive.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20150408/7b58c4e1/attachment.html>