[Poppler-bugs] [Bug 89952] Memory Leak in CairoFreeTypeFont::create

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89952

--- Comment #6 from Carlos Garcia Campos <carlosgc at gnome.org> ---
(In reply to Jason Crain from comment #5)
> Created attachment 114973 [details] [review]
> Fix memory leak in CairoFreeTypeFont::create
> 
> I was hoping it would be less confusing as separate patches. :)

And confused me :-P

> I've squashed the patches.  This frees things in three places:
> 
> - In _ft_done_face, free the embedded font data.
> - In _ft_new_face, free the embedded font data if it's found to be a
> duplicate.

You should also free the bytes in _ft_new_face when FT_New_Memory_Face fails,
no?

> - In CairoFreeTypeFont::create, free the embedded font data and codeToGID
> array if font creation fails.

Good catch! This one is probably more unrelated and could be in a separate
patch, but I'm fine with a single patch too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20150410/761ce761/attachment.html>