[Poppler-bugs] [Bug 89136] Annotations of /Subtype /Popup are not added to /Annots array of a page

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89136

--- Comment #15 from philipp.reinkemeier at offis.de ---
(In reply to Carlos Garcia Campos from comment #14)
> Comment on attachment 113520 [details] [review]
> Add annotation of Subtype Popup to pdf page
> 
> Review of attachment 113520 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: poppler/Page.cc
> @@ +450,5 @@
> > +  AnnotMarkup *annot_markup = dynamic_cast<AnnotMarkup*>(annot);
> > +  if (annot_markup) {
> > +    AnnotPopup *annot_popup = annot_markup->getPopup();
> > +    if (annot_popup) {
> > +      this->addAnnot(annot_popup);
> 
> So, this makes me wonder, should we also remove the popup associated to a
> markup annotation in Page::removeAnnot() when a markup annot is given?

Fortunately this does already happen. Method Page::removeAnnot(Annot *annot)
calls annot->removeReferencedObjects(). This in turn is virtual and
AnnotMarkup::removeReferencedObjects() calls Page::removeAnnot() again, this
time with its AnnotPopup.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20150419/611fce05/attachment.html>